snuyanzin commented on code in PR #21934:
URL: https://github.com/apache/flink/pull/21934#discussion_r1145983345
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonDeserializer.java:
##########
@@ -217,9 +218,10 @@ private static RexNode deserializeSarg(
builder.add(range);
}
}
- final boolean containsNull =
sargNode.required(FIELD_NAME_CONTAINS_NULL).booleanValue();
- return rexBuilder.makeSearchArgumentLiteral(
- Sarg.of(containsNull, builder.build()), relDataType);
+ final RexUnknownAs nullAs =
Review Comment:
The main change Calcite level was movement from 2-value sarg to 3-value sarg
and replacement of `boolean containsNull` with `RexUnknownAs nullAs`. I guess
it is possible to deserialize old plans. I will see what could be done here
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/RexNodeJsonDeserializer.java:
##########
@@ -217,9 +218,10 @@ private static RexNode deserializeSarg(
builder.add(range);
}
}
- final boolean containsNull =
sargNode.required(FIELD_NAME_CONTAINS_NULL).booleanValue();
- return rexBuilder.makeSearchArgumentLiteral(
- Sarg.of(containsNull, builder.build()), relDataType);
+ final RexUnknownAs nullAs =
Review Comment:
The main change on Calcite level was movement from 2-value sarg to 3-value
sarg and replacement of `boolean containsNull` with `RexUnknownAs nullAs`. I
guess it is possible to deserialize old plans. I will see what could be done
here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
