snuyanzin commented on code in PR #21934:
URL: https://github.com/apache/flink/pull/21934#discussion_r1149294185
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/PreValidateReWriter.scala:
##########
@@ -330,7 +331,7 @@ object PreValidateReWriter {
if (currentNodes.size > 0) {
fieldNodes.addAll(currentNodes)
}
-
fixedNodes.add(SqlStdOperatorTable.ROW.createCall(value.getParserPosition,
fieldNodes))
+
fixedNodes.add(FlinkSqlOperatorTable.ROW.createCall(value.getParserPosition,
fieldNodes))
Review Comment:
yes, you are right, thank you!
I've doubled checked it in generated code and `SqlStdOperatorTable.ROW` is
used there...
So I replaced it with a version in `calcite` package
> Are you sure this change is enough to replace `SqlStdOperatorTable.ROW`?
IIRC the generated code in the parser usually has `SqlStdOperatorTable` hard
coded. Can you verify? If this is the case we need to shadow the Calcite class
instead.
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/PreValidateReWriter.scala:
##########
@@ -330,7 +331,7 @@ object PreValidateReWriter {
if (currentNodes.size > 0) {
fieldNodes.addAll(currentNodes)
}
-
fixedNodes.add(SqlStdOperatorTable.ROW.createCall(value.getParserPosition,
fieldNodes))
+
fixedNodes.add(FlinkSqlOperatorTable.ROW.createCall(value.getParserPosition,
fieldNodes))
Review Comment:
yes, you are right, thank you!
I've doubled checked it in generated code and `SqlStdOperatorTable.ROW` is
used there...
So I replaced it with a version in `calcite` package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
