snuyanzin commented on code in PR #21934:
URL: https://github.com/apache/flink/pull/21934#discussion_r1148640804
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/calcite/FlinkLogicalRelFactories.scala:
##########
@@ -174,6 +174,7 @@ object FlinkLogicalRelFactories {
def createCorrelate(
left: RelNode,
right: RelNode,
+ hints: util.List[RelHint],
Review Comment:
It looks it was implemented in Flink in a different way within
https://issues.apache.org/jira/browse/FLINK-29280.
And it was one of the reason of having Calcite's `RelDecorrelator` in
Flink's repo.
May be it would make sense to create a separate issue to move to Calcite's
hints implementation... (probably after update to 1.31.0 where the major part
of hint support was added in Calcite)
Howbeit there are still other issues requiring Calcite's `RelDecorrelator`
in Flink's repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
