MartijnVisser commented on code in PR #119:
URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1153091344


##########
flink-shaded-netty-4/src/main/resources/META-INF/NOTICE:
##########
@@ -6,36 +6,37 @@ The Apache Software Foundation (http://www.apache.org/).
 
 This project bundles the following dependencies under the Apache Software 
License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt)
 
-- io.netty:netty-all:4.1.82.Final
-- io.netty:netty-buffer:4.1.82.Final
-- io.netty:netty-codec:4.1.82.Final
-- io.netty:netty-codec-dns:4.1.82.Final
-- io.netty:netty-codec-haproxy:4.1.82.Final
-- io.netty:netty-codec-http:4.1.82.Final
-- io.netty:netty-codec-http2:4.1.82.Final
-- io.netty:netty-codec-memcache:4.1.82.Final
-- io.netty:netty-codec-mqtt:4.1.82.Final
-- io.netty:netty-codec-redis:4.1.82.Final
-- io.netty:netty-codec-smtp:4.1.82.Final
-- io.netty:netty-codec-socks:4.1.82.Final
-- io.netty:netty-codec-stomp:4.1.82.Final
-- io.netty:netty-codec-xml:4.1.82.Final
-- io.netty:netty-common:4.1.82.Final
-- io.netty:netty-handler:4.1.82.Final
-- io.netty:netty-handler-proxy:4.1.82.Final
-- io.netty:netty-resolver:4.1.82.Final
-- io.netty:netty-resolver-dns:4.1.82.Final
-- io.netty:netty-resolver-dns-classes-macos:4.1.82.Final
-- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.1.82.Final
-- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.1.82.Final
-- io.netty:netty-transport:4.1.82.Final
-- io.netty:netty-transport-classes-epoll:4.1.82.Final
-- io.netty:netty-transport-classes-kqueue:4.1.82.Final
-- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.82.Final
-- io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.82.Final
-- io.netty:netty-transport-native-kqueue:osx-x86_64:4.1.82.Final
-- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.1.82.Final
-- io.netty:netty-transport-native-unix-common:4.1.82.Final
-- io.netty:netty-transport-rxtx:4.1.82.Final
-- io.netty:netty-transport-sctp:4.1.82.Final
-- io.netty:netty-transport-udt:4.1.82.Final
\ No newline at end of file
+- io.netty:netty-all:4.1.90.Final
+- io.netty:netty-buffer:4.1.90.Final
+- io.netty:netty-codec-dns:4.1.90.Final

Review Comment:
   A new run at 
https://dev.azure.com/martijn0323/Flink/_build/results?buildId=4048&view=results
 has shown that the test is now passing, except the Python one.
   
   The Python failure is caused by Pulsar, which uses flink-shaded but that 
still points to `guava30` instead of `guava31`. I don't think that's a blocker 
for this PR, but a necessary update that needs to happen in Pulsar and then in 
PyFlink to point to the new Pulsar artifact. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to