MartijnVisser commented on code in PR #119: URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1153113838
########## flink-shaded-netty-4/src/main/resources/META-INF/NOTICE: ########## @@ -6,36 +6,37 @@ The Apache Software Foundation (http://www.apache.org/). This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) -- io.netty:netty-all:4.1.82.Final -- io.netty:netty-buffer:4.1.82.Final -- io.netty:netty-codec:4.1.82.Final -- io.netty:netty-codec-dns:4.1.82.Final -- io.netty:netty-codec-haproxy:4.1.82.Final -- io.netty:netty-codec-http:4.1.82.Final -- io.netty:netty-codec-http2:4.1.82.Final -- io.netty:netty-codec-memcache:4.1.82.Final -- io.netty:netty-codec-mqtt:4.1.82.Final -- io.netty:netty-codec-redis:4.1.82.Final -- io.netty:netty-codec-smtp:4.1.82.Final -- io.netty:netty-codec-socks:4.1.82.Final -- io.netty:netty-codec-stomp:4.1.82.Final -- io.netty:netty-codec-xml:4.1.82.Final -- io.netty:netty-common:4.1.82.Final -- io.netty:netty-handler:4.1.82.Final -- io.netty:netty-handler-proxy:4.1.82.Final -- io.netty:netty-resolver:4.1.82.Final -- io.netty:netty-resolver-dns:4.1.82.Final -- io.netty:netty-resolver-dns-classes-macos:4.1.82.Final -- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.1.82.Final -- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.1.82.Final -- io.netty:netty-transport:4.1.82.Final -- io.netty:netty-transport-classes-epoll:4.1.82.Final -- io.netty:netty-transport-classes-kqueue:4.1.82.Final -- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.82.Final -- io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.82.Final -- io.netty:netty-transport-native-kqueue:osx-x86_64:4.1.82.Final -- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.1.82.Final -- io.netty:netty-transport-native-unix-common:4.1.82.Final -- io.netty:netty-transport-rxtx:4.1.82.Final -- io.netty:netty-transport-sctp:4.1.82.Final -- io.netty:netty-transport-udt:4.1.82.Final \ No newline at end of file +- io.netty:netty-all:4.1.90.Final +- io.netty:netty-buffer:4.1.90.Final +- io.netty:netty-codec-dns:4.1.90.Final Review Comment: > I guess we should also update [<curator.version/> in Flink's parent pom](https://github.com/apache/flink/blob/master/pom.xml#L143) to keep it consistent. Yes, but I believe we first have to release this newer version of flink-shaded before we can open the PR towards Flink. > On that note: Why do we keep a separate curator dependency for tests? Is it because we don't necessarily need zookeeper in certain modules and want to keep it more light-weight by relying on curator's `TestingZooKeeperServer` implementation? I defer to @zentol for that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
