MartijnVisser commented on code in PR #119: URL: https://github.com/apache/flink-shaded/pull/119#discussion_r1153151942
########## flink-shaded-netty-4/src/main/resources/META-INF/NOTICE: ########## @@ -6,36 +6,37 @@ The Apache Software Foundation (http://www.apache.org/). This project bundles the following dependencies under the Apache Software License 2.0 (http://www.apache.org/licenses/LICENSE-2.0.txt) -- io.netty:netty-all:4.1.82.Final -- io.netty:netty-buffer:4.1.82.Final -- io.netty:netty-codec:4.1.82.Final -- io.netty:netty-codec-dns:4.1.82.Final -- io.netty:netty-codec-haproxy:4.1.82.Final -- io.netty:netty-codec-http:4.1.82.Final -- io.netty:netty-codec-http2:4.1.82.Final -- io.netty:netty-codec-memcache:4.1.82.Final -- io.netty:netty-codec-mqtt:4.1.82.Final -- io.netty:netty-codec-redis:4.1.82.Final -- io.netty:netty-codec-smtp:4.1.82.Final -- io.netty:netty-codec-socks:4.1.82.Final -- io.netty:netty-codec-stomp:4.1.82.Final -- io.netty:netty-codec-xml:4.1.82.Final -- io.netty:netty-common:4.1.82.Final -- io.netty:netty-handler:4.1.82.Final -- io.netty:netty-handler-proxy:4.1.82.Final -- io.netty:netty-resolver:4.1.82.Final -- io.netty:netty-resolver-dns:4.1.82.Final -- io.netty:netty-resolver-dns-classes-macos:4.1.82.Final -- io.netty:netty-resolver-dns-native-macos:osx-x86_64:4.1.82.Final -- io.netty:netty-resolver-dns-native-macos:osx-aarch_64:4.1.82.Final -- io.netty:netty-transport:4.1.82.Final -- io.netty:netty-transport-classes-epoll:4.1.82.Final -- io.netty:netty-transport-classes-kqueue:4.1.82.Final -- io.netty:netty-transport-native-epoll:linux-x86_64:4.1.82.Final -- io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.82.Final -- io.netty:netty-transport-native-kqueue:osx-x86_64:4.1.82.Final -- io.netty:netty-transport-native-kqueue:osx-aarch_64:4.1.82.Final -- io.netty:netty-transport-native-unix-common:4.1.82.Final -- io.netty:netty-transport-rxtx:4.1.82.Final -- io.netty:netty-transport-sctp:4.1.82.Final -- io.netty:netty-transport-udt:4.1.82.Final \ No newline at end of file +- io.netty:netty-all:4.1.90.Final +- io.netty:netty-buffer:4.1.90.Final +- io.netty:netty-codec-dns:4.1.90.Final Review Comment: > Do we know why these classes are missing? 🤔 No, but maybe because there's still pointing to Pulsar for Flink 1.16 https://github.com/apache/flink/blob/master/flink-python/pom.xml#L293 and that now results in a conflict -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
