reswqa commented on code in PR #22574:
URL: https://github.com/apache/flink/pull/22574#discussion_r1193755613
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/batch/sql/FileSystemTestCsvITCase.scala:
##########
@@ -32,12 +35,11 @@ class FileSystemTestCsvITCase extends
BatchFileSystemITCaseBase {
override def getScheme: String = "test"
- @After
+ @AfterEach
def close(): Unit = {
val path = new Path(resultPath)
- assertEquals(
- s"File $resultPath is not closed",
- 0,
- TestFileSystem.getNumberOfUnclosedOutputStream(path))
+ if (TestFileSystem.getNumberOfUnclosedOutputStream(path) != 0) {
+ Assertions.fail(s"File $resultPath is not closed");
+ }
Review Comment:
When I tried using `Assertions.assertThat(xxx).as(yyy).isEqualTo(zzz)`, I
found that there seemed to be some bugs that caused the IDE to think it
couldn't compile. This is indeed very strange, causing me to have to deal with
it this way. Do you have any other ideas?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
