reswqa commented on code in PR #22574:
URL: https://github.com/apache/flink/pull/22574#discussion_r1194168520
##########
flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/planner/runtime/stream/sql/StreamFileSystemITCaseBase.scala:
##########
@@ -23,17 +23,20 @@ import org.apache.flink.table.api.TableEnvironment
import org.apache.flink.table.api.bridge.scala._
import org.apache.flink.table.planner.runtime.FileSystemITCaseBase
import org.apache.flink.table.planner.runtime.utils.{AbstractExactlyOnceSink,
StreamingTestBase, TestingAppendSink, TestSinkUtil}
+import
org.apache.flink.testutils.junit.extensions.parameterized.NoOpTestExtension
import org.apache.flink.types.Row
-import org.junit.{Assert, Before, Test}
-import org.junit.Assert.assertEquals
+import org.assertj.core.api.Assertions.assertThat
+import org.junit.jupiter.api.{BeforeEach, Test}
+import org.junit.jupiter.api.extension.ExtendWith
import scala.collection.{mutable, Seq}
/** Streaming [[FileSystemITCaseBase]]. */
+@ExtendWith(Array(classOf[NoOpTestExtension]))
abstract class StreamFileSystemITCaseBase extends StreamingTestBase with
FileSystemITCaseBase {
Review Comment:
I did notice this issue, but I found that the `lifecycle` method like
`before` in `StreamingTestBase ` double annotationed with `@Before` and
`@BeforeEach`.
```
@Before
@BeforeEach
def before(): Unit = {
this.env = StreamExecutionEnvironment.getExecutionEnvironment
env.setParallelism(4)
if (enableObjectReuse) {
this.env.getConfig.enableObjectReuse()
}
val setting = EnvironmentSettings.newInstance().inStreamingMode().build()
this.tEnv = StreamTableEnvironment.create(env, setting)
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
