zentol commented on code in PR #22718:
URL: https://github.com/apache/flink/pull/22718#discussion_r1221338836
##########
flink-runtime/src/test/java/org/apache/flink/runtime/execution/librarycache/BlobLibraryCacheManagerTest.java:
##########
@@ -585,6 +586,37 @@ public void releaseUserCodeClassLoader_willRegisterOnce()
releaseHookLatch.await();
}
+ @Test
+ public void testUseSystemClassLoader() throws IOException,
InterruptedException {
+ final BlobLibraryCacheManager libraryCacheManager =
+ new TestingBlobLibraryCacheManagerBuilder().build();
+
+ final LibraryCacheManager.ClassLoaderLease classLoaderLease =
+ libraryCacheManager.registerClassLoaderLease(new JobID(),
true);
+ UserCodeClassLoader userCodeClassLoader1 =
+ classLoaderLease.getOrResolveClassLoader(
+ Collections.emptyList(), Collections.emptyList());
+
+ assertTrue(userCodeClassLoader1 instanceof SimpleUserCodeClassLoader);
Review Comment:
hmm....what kind of jobs actually don't have required jars? Does that also
cover SQL jobs using a Flink connector provided in via lib?
If so, then this could break things if a (Flink) connector provided via lib
uses a CL hook to be run some cleanup on job termination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
