FangYongs commented on code in PR #22718:
URL: https://github.com/apache/flink/pull/22718#discussion_r1233966178
##########
flink-runtime/src/main/java/org/apache/flink/runtime/execution/librarycache/LibraryCacheManager.java:
##########
@@ -43,9 +43,11 @@ public interface LibraryCacheManager {
* job will be valid as long as there exists a valid lease for this job.
*
* @param jobId jobId for which to register a new class loader lease
+ * @param useSystemClassLoader use system class loader if the jars or
classpaths of job are
+ * empty
* @return a new class loader lease for the given job
*/
- ClassLoaderLease registerClassLoaderLease(JobID jobId);
+ ClassLoaderLease registerClassLoaderLease(JobID jobId, boolean
useSystemClassLoader);
Review Comment:
Thanks @zentol , it sounds good to me which will makes codes are more clear.
I have updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
