FangYongs commented on code in PR #22718:
URL: https://github.com/apache/flink/pull/22718#discussion_r1222933894
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java:
##########
@@ -1191,7 +1191,7 @@ private TaskExecutorJobServices
registerNewJobAndCreateServices(
permanentBlobService.registerJob(jobId);
return TaskExecutorJobServices.create(
- libraryCacheManager.registerClassLoaderLease(jobId),
+ libraryCacheManager.registerClassLoaderLease(jobId, false),
Review Comment:
Good point! Currently we can use system classloader in TaskManager directly
even when the `classpaths` is empty. That's because the index number for the
name of generated class in flink sql is per job, and there will be the same
class name in different job. If we use system classloader for sql in
TaskManager, it will cause confliction for these classes. We have created an
issue for TaskManager: https://issues.apache.org/jira/browse/FLINK-28691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
