morhidi commented on PR #613:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/613#issuecomment-1581701588

   > > Thanks @morhidi . I think this metric is useful for monitoring the 
autoscaler especially if automatic scaling is turned off.
   > > However I think we need to add some logic to update the recommended 
parallelism when the job status / jobgraph changes as well. Whenever we reset 
the metrics we should also reset the recommended parallelism to the current job 
vertex parallelism. What do you think?
   > > cc @mxm
   > 
   > Makes sense to me, I'll sync-up with you offline and amend the PR with the 
recommended changes
   
   @gyfora I've updated the PR description with the logic we discussed offline, 
and implemented the changes we agreed, have another look pls


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to