morhidi commented on PR #613: URL: https://github.com/apache/flink-kubernetes-operator/pull/613#issuecomment-1583359865
> Thanks @morhidi! That's a very usual addition. I'm just a bit concerned about the complexity here. I think this could have been implemented a bit simpler. If we were to expose the recommended parallelism as an evaluated scaling metric, the changes would be a few lines of code. We could reuse all existing logic to expose metrics. > > I would also appreciate if we could keep the unrelated changes / refactoring to a bare minimum. This makes reviewing much easier and keeps the commit history clean. > > All in all, this will be super useful. Thanks @mxm for the comprehensice review. My original thought was to implement this as an evaluated metric, but the idea was abandoned and went on this rout instead. I'll give that idea another shot, also trying not to be so disruptive with refactoring on a single PR :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
