gyfora commented on code in PR #613:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/613#discussion_r1222565376
##########
flink-kubernetes-operator-autoscaler/src/main/java/org/apache/flink/kubernetes/operator/autoscaler/ScalingMetricCollector.java:
##########
@@ -100,7 +100,9 @@ public CollectedMetricHistory updateMetrics(
cleanup(cr);
metricHistory.clear();
metricCollectionStartTs = now;
+ cleanupRecommendedParallelisms(recommendedParallelisms,
resourceID);
}
+ var topology = getJobTopology(flinkService, cr, conf, autoscalerInfo);
Review Comment:
Moving the topology assignment is not necessary right? (I made changes to
this logic in my open PR so it would be better to not move this if not
necessary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
