yuchengxin commented on code in PR #22767:
URL: https://github.com/apache/flink/pull/22767#discussion_r1241012686
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/WatermarkPushDownSpec.java:
##########
@@ -104,11 +121,25 @@ public String getDigests(SourceAbilityContext context) {
watermarkExpr,
JavaScalaConversionUtil.toScala(
context.getSourceRowType().getFieldNames()));
- if (idleTimeoutMillis > 0) {
- return String.format(
- "watermark=[%s], idletimeout=[%d]", expressionStr,
idleTimeoutMillis);
+ String digest = String.format("watermark=[%s]", expressionStr);
+ long actualIdleTimeoutMillis = calculateIdleTimeoutMillis();
+ if (actualIdleTimeoutMillis > 0) {
+ digest = String.format("%s, idletimeout=[%d]", digest,
actualIdleTimeoutMillis);
Review Comment:
The original name is `idletimeout`, it needs to be consistent with the
original name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
