yuchengxin commented on code in PR #22767:
URL: https://github.com/apache/flink/pull/22767#discussion_r1241076422
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/WatermarkPushDownSpec.java:
##########
@@ -81,12 +89,21 @@ public void apply(DynamicTableSource tableSource,
SourceAbilityContext context)
Option.apply("context"));
WatermarkGeneratorSupplier<RowData> supplier =
- new
GeneratedWatermarkGeneratorSupplier(generatedWatermarkGenerator);
+ new GeneratedWatermarkGeneratorSupplier(
+ generatedWatermarkGenerator, watermarkParams);
WatermarkStrategy<RowData> watermarkStrategy =
WatermarkStrategy.forGenerator(supplier);
- if (idleTimeoutMillis > 0) {
+ if (watermarkParams != null &&
watermarkParams.alignWatermarkEnabled()) {
+ watermarkStrategy =
+ watermarkStrategy.withWatermarkAlignment(
Review Comment:
We can't，the param of `WatermarkStrategy.forGenerator` is
`WatermarkGeneratorSupplier`, which is just an interface without
watermarkParams, we can't get watermarkParams from `WatermarkGeneratorSupplier`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
