yuchengxin commented on code in PR #22767:
URL: https://github.com/apache/flink/pull/22767#discussion_r1241117207
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/abilities/source/WatermarkPushDownSpec.java:
##########
@@ -131,4 +162,12 @@ public boolean equals(Object o) {
public int hashCode() {
return Objects.hash(super.hashCode(), watermarkExpr,
idleTimeoutMillis);
}
+
+ private long calculateIdleTimeoutMillis() {
+ long actualIdleTimeoutMillis = idleTimeoutMillis;
+ if (watermarkParams != null && watermarkParams.getSourceIdleTimeout()
> 0) {
Review Comment:
User may set idle timeout to zero actually, I hive fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
