hanyuzheng7 commented on code in PR #22842:
URL: https://github.com/apache/flink/pull/22842#discussion_r1252343611


##########
flink-python/pyflink/table/expression.py:
##########
@@ -1558,6 +1558,18 @@ def map_keys(self) -> 'Expression':
         """
         return _unary_op("mapKeys")(self)
 
+    @property
+    def map_union(self, map2) -> 'Expression':
+        """
+        Returns a map created by merging two maps, 'map1' and 'map2'.
+        These two maps should have same data structure. If there are 
overlapping keys,

Review Comment:
   `Returns a map created by merging two maps, 'map1' and 'map2'. These two 
maps should have same type for their key and value individually. If there are 
overlapping keys, the value from 'map2' will overwrite the value from 'map1'. 
If any of maps is null, return null.`
   
   What I want to say is that two maps' key and value should have same data 
type.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to