[
https://issues.apache.org/jira/browse/FLINK-32804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761745#comment-17761745
]
Matt Wang commented on FLINK-32804:
-----------------------------------
[~renqs] [~pgaref] hi, I have tested the functions of LIFP-304 here. Overall,
the functions are OK, but I have also encountered some minor problems:
1. When FailureEnricherUtils loads FailureEnricher, if
`jobmanager.failure-enrichers` is configured but not loaded, I think it should
throw an exception or print some ERROR logs. I created a [FLINK-33022 When
FailureEnricherUtils load FailureEnricherFactory failed should throw exception
or add some error logs](https://issues.apache.org /jira/browse/FLINK-33022) to
follow up;
2. FLIP-304 introduces the `LabeledGlobalFailureHandler` interface. I think the
`GlobalFailureHandler` interface can be removed in the future to avoid the
existence of interfaces with duplicate functions. This can be promoted in
future versions;
3. Regarding the user documentation, I left some comments. The user
documentation is very helpful, and the code integration needs to be promoted as
soon as possible; [~pgaref]
4. https://issues.apache.org/jira/browse/FLINK-31895 about E2E test Here I
think it needs to be promoted as soon as possible. If there is a Demo example,
it will be more helpful to users.
here is my test:
First, I implemented a custom FailureEnricher and FailureEnricherFactory, and
placed it in the plugins directory
!image-2023-09-04-16-58-29-329.png|width=898,height=330!
!image-2023-09-04-17-00-16-413.png|width=871,height=238!
Secondly, I build a test job. The test job will throw an exception when
running. Ideally, it will hit the CustomEnricher.
!image-2023-09-04-17-02-41-760.png|width=867,height=433!
Finally, through restful api, you can see that corresponding exceptions will
have corresponding label information.
!image-2023-09-04-17-03-25-452.png|width=875,height=20!
!image-2023-09-04-17-04-21-682.png|width=886,height=589!
> Release Testing: Verify FLIP-304: Pluggable failure handling for Apache Flink
> -----------------------------------------------------------------------------
>
> Key: FLINK-32804
> URL: https://issues.apache.org/jira/browse/FLINK-32804
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.18.0
> Reporter: Qingsheng Ren
> Assignee: Matt Wang
> Priority: Major
> Fix For: 1.18.0
>
> Attachments: image-2023-09-04-16-58-29-329.png,
> image-2023-09-04-17-00-16-413.png, image-2023-09-04-17-02-41-760.png,
> image-2023-09-04-17-03-25-452.png, image-2023-09-04-17-04-21-682.png
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
