[
https://issues.apache.org/jira/browse/FLINK-32804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17762443#comment-17762443
]
Panagiotis Garefalakis commented on FLINK-32804:
------------------------------------------------
Hey [~wangm92] – thanks for the detailed update! Answers inline
{quote}1. When FailureEnricherUtils loads FailureEnricher, if
`jobmanager.failure-enrichers` is configured but not loaded, I think it should
throw an exception or print some ERROR logs. I created
Jira(https://issues.apache.org/jira/browse/FLINK-33022) a to follow up;
{quote}
Happy to take care of this
{quote}2. FLIP-304 introduces the `LabeledGlobalFailureHandler` interface. I
think the `GlobalFailureHandler` interface can be removed in the future to
avoid the existence of interfaces with duplicate functions. This can be
promoted in future versions;
{quote}
Opened FLINK-31508 to work on this
{quote}3. Regarding the user documentation, I left some comments. The user
documentation is very helpful, and the code integration needs to be promoted as
soon as possible; [~pgaref]
{quote}
Updated documentation PR – let me know what you think
{quote}4. https://issues.apache.org/jira/browse/FLINK-31895 about E2E test
Here I think it needs to be promoted as soon as possible. If there is a Demo
example, it will be more helpful to users.
{quote}
Lets split this to 2 tickets, one about e2e tests and one adding a demo
> Release Testing: Verify FLIP-304: Pluggable failure handling for Apache Flink
> -----------------------------------------------------------------------------
>
> Key: FLINK-32804
> URL: https://issues.apache.org/jira/browse/FLINK-32804
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.18.0
> Reporter: Qingsheng Ren
> Assignee: Matt Wang
> Priority: Major
> Fix For: 1.18.0
>
> Attachments: image-2023-09-04-16-58-29-329.png,
> image-2023-09-04-17-00-16-413.png, image-2023-09-04-17-02-41-760.png,
> image-2023-09-04-17-03-25-452.png, image-2023-09-04-17-04-21-682.png
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
