davidradl commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1347416170
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -167,12 +170,19 @@ public ExecNodeContext withId(int id) {
*/
@JsonValue
public String getTypeAsString() {
+ if (name == null || version == null) {
+ throw new TableException(
+ String.format(
+ "Can not serialize ExecNode with id: %d. Missing
type, this is a bug,"
+ + " please file a ticket.",
Review Comment:
I suggest rephrasing to raising a Jira and including the url.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ExecNodeGraphJsonSerializerTest.java:
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.FlinkVersion;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfig;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeContext;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraph;
+
+import
org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectWriter;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests for {@link ExecNodeGraphJsonSerializer}. */
+class ExecNodeGraphJsonSerializerTest {
+
+ @Test
+ void testSerializingUnsupportedNode() {
+ final ObjectWriter objectWriter =
+
JsonSerdeUtil.createObjectWriter(JsonSerdeTestUtil.configuredSerdeContext());
+ assertThatThrownBy(
+ () ->
+ objectWriter.writeValueAsString(
+ new ExecNodeGraph(
+ FlinkVersion.v1_18,
+ Collections.singletonList(new
NoAnnotationNode()))))
+ .hasMessageContaining(
+ "Can not serialize ExecNode with id: 10. Missing type,
this is a bug, please file a ticket");
Review Comment:
I suggest rephrasing to raising a Jira and including the url.
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -105,6 +105,9 @@ private ExecNodeContext(@Nullable Integer id, String name,
Integer version) {
public ExecNodeContext(String value) {
this.id = null;
String[] split = value.split("_");
+ if ("null".equals(split[0]) || "null".equals(split[1])) {
Review Comment:
I am not very familiar with this code; you are saying that the value can
come through as either null_xxx or yyy_null.
Is there not a way to test for these nulls prior to calling this.
Also I wonder if you should check for the failure of
Integer.valueOf(split[1]); and give a nicer message in that case.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/UnsupportedNodesInPlanTest.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec;
+
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.PlanReference;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.planner.utils.TableTestBase;
+
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests for deserialising invalid {@link
org.apache.flink.table.api.CompiledPlan}. */
+public class UnsupportedNodesInPlanTest extends TableTestBase {
+
+ @Test
+ public void testInvalidType() {
+ final TableEnvironment tEnv =
+ TableEnvironment.create(EnvironmentSettings.inStreamingMode());
+ assertThatThrownBy(
+ () ->
+ tEnv.loadPlan(
+ PlanReference.fromResource(
+
"/jsonplan/testInvalidTypeJsonPlan.json")))
+ .hasRootCauseMessage(
+ "Unsupported exec node type: 'null_null'.");
Review Comment:
can we test xxx_null as well, so we test the `|| "null".equals(split[1])`
part of the if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
