dawidwys commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1350384802
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -167,12 +170,19 @@ public ExecNodeContext withId(int id) {
*/
@JsonValue
public String getTypeAsString() {
+ if (name == null || version == null) {
+ throw new TableException(
+ String.format(
+ "Can not serialize ExecNode with id: %d. Missing
type, this is a bug,"
+ + " please file a ticket.",
Review Comment:
The current phrasing is in line with other similar places. I would also not
use a proprietary system name in the code. It's not guaranteed Apache and Flink
in particular continues using JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
