1996fanrui commented on PR #698: URL: https://github.com/apache/flink-kubernetes-operator/pull/698#issuecomment-1790284984
Hi @gyfora @mxm , I have addressed all comments, added README, finished all unit tests and ran it locally with fat jar. Please take a look in your free time, thanks~ > If we are adding the fatjar + also include the respective notice file. Hi @gyfora , I didn't understand the notice file. Could you elaborate on it? ------------------------------- > 2. will `YarnJobFetcher` be a seperate process or demon in flink-yarn cluster ? Hi @Samrat002 , thank you for your review! I have added a `README.md` to explain some details of `Standalone Autoscaler`, it includes how it works with `JobListFetcher`. `YarnJobListFetcher` is an implemetation of `JobListFetcher`, I think they are similar. you can take a look, thanks~ > 1. can you please help understand how `YarnJobFetcher` can be used in hadoop cluster and deploy flink-yarn ? How exactly it can be used to serve autoscaling ? As I understand, users need to pass the `yarn resource manger address` to `YarnJobListFetcher`, `YarnJobListFetcher` can fetch job list by 2 steps: 1 . `YarnJobListFetcher` can fetch all flink clusters from yarn cluster based on rest api. 2. Step2 is totally same with current `FlinkClusterJobListFetcher`, because `FlinkClusterJobListFetcher` works with single flink cluster. Please correct me if my understanding is wrong, thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
