1996fanrui commented on code in PR #698: URL: https://github.com/apache/flink-kubernetes-operator/pull/698#discussion_r1377543297
########## flink-autoscaler/src/main/java/org/apache/flink/autoscaler/standalone/JobListFetcher.java: ########## @@ -0,0 +1,31 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.autoscaler.standalone; + +import org.apache.flink.annotation.Experimental; +import org.apache.flink.autoscaler.JobAutoScalerContext; +import org.apache.flink.metrics.MetricGroup; + +import java.util.List; + +/** The JobListFetcher will fetch the jobContext of all jobs. */ +@Experimental +public interface JobListFetcher<KEY> { + + List<JobAutoScalerContext<KEY>> fetch(MetricGroup metricGroup) throws Exception; Review Comment: And one important reason: When the job is restarted, the JobID will change. In order to support job non-in-place restart, it's better to use `JobAutoScalerContext<KEY>` instead of `JobAutoScalerContext<JobID>`. In general, other platform has the unique job id or job name, it likes metadata name of kubernetes. The `FlinkClusterJobListFetcher` just support fetch `List<JobAutoScalerContext<JobID>>`, if we just keep `FlinkClusterJobListFetcher`, it's hard to let `StandaloneAutoscaler` generic. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
