snuyanzin commented on PR #79:
URL: 
https://github.com/apache/flink-connector-jdbc/pull/79#issuecomment-1818476193

   >it should not be manipulating filters into join conditions for predicate 
pushdown.
   
   however only connector could say whether source supports certain types of 
push down or not, for different connectors it's different, however that's 
probably another topic
   
   yes, i think it would make sense to include the test
   since tablesourcescan doesn't show pushdown condition it would make sense to 
have both tests: plan and e2e which you've added at the beginning
   
   >with no join condition.
   
   yes that's the thing that join condition was mentioned in ast and then 
because of pushdown wasmoved to source connector
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to