snuyanzin commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1398835711
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcDynamicTableSourceITCase.java:
##########
@@ -356,6 +356,152 @@ void testLookupJoin(Caching caching) {
}
}
+ @ParameterizedTest
+ @EnumSource(Caching.class)
+ void testLookupJoinWithFilter(Caching caching) {
+ // Create JDBC lookup table
+ List<String> cachingOptions = Collections.emptyList();
+ if (caching.equals(Caching.ENABLE_CACHE)) {
Review Comment:
nit:
`caching` is enum i.e. it could be compared with just `=` ...
also at line 423 it is compared with `=`, it's better to follow same
approach across the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
