davidradl commented on code in PR #79:
URL:
https://github.com/apache/flink-connector-jdbc/pull/79#discussion_r1399263661
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTablePlanTest.java:
##########
@@ -64,4 +82,14 @@ public void testFilterPushdown() {
util.verifyExecPlan(
"SELECT id, time_col, real_col FROM jdbc WHERE id = 900001 AND
time_col <> TIME '11:11:11' OR double_col >= -1000.23");
}
+
+ @Test
+ /**
+ * Note the join condition is not present in the optimized plan, as it is
handled in the JDBC java code,
+ * where it adds the join conditions to the select statement string.
+ */
Review Comment:
Ok that makes sense, though I wonder if the optimisation plan could be aware
of what the connector supports, so it could optimize the pushdowns in a
standard way. Or are there more variation between the way that different
databases do predicate pushdown or the like.
##########
flink-connector-jdbc/src/test/java/org/apache/flink/connector/jdbc/table/JdbcTablePlanTest.java:
##########
@@ -64,4 +82,14 @@ public void testFilterPushdown() {
util.verifyExecPlan(
"SELECT id, time_col, real_col FROM jdbc WHERE id = 900001 AND
time_col <> TIME '11:11:11' OR double_col >= -1000.23");
}
+
+ @Test
+ /**
+ * Note the join condition is not present in the optimized plan, as it is
handled in the JDBC java code,
+ * where it adds the join conditions to the select statement string.
+ */
Review Comment:
Ok that makes sense, though I wonder if the optimisation plan could be aware
of what the connector supports, so it could optimize the pushdowns in a
standard way. Or are there more variation between the way that different
databases do predicate pushdown or the like.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
