XComp commented on code in PR #23770:
URL: https://github.com/apache/flink/pull/23770#discussion_r1403027423
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskTest.java:
##########
@@ -50,7 +50,7 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.fail;
-public class ReduceTaskTest extends
DriverTestBase<RichGroupReduceFunction<Record, Record>> {
+public class ReduceTaskTest extends DriverTestBase<GroupReduceFunction<Record,
Record>> {
Review Comment:
Same here: Were those changes made accidentally?
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/CoGroupTaskTest.java:
##########
@@ -406,46 +328,28 @@ void testCancelCoGroupTaskWhileCoGrouping() {
getTaskConfig().setDriverPairComparator(RecordPairComparatorFactory.get());
getTaskConfig().setDriverStrategy(DriverStrategy.CO_GROUP);
- final CoGroupDriver<Record, Record, Record> testTask =
- new CoGroupDriver<Record, Record, Record>();
+ final CoGroupDriver<Record, Record, Record> testTask = new
CoGroupDriver<>();
- try {
- addInput(new UniformRecordGenerator(keyCnt, valCnt, true));
- addInput(new UniformRecordGenerator(keyCnt, valCnt, true));
- } catch (Exception e) {
- e.printStackTrace();
- fail("The test caused an exception.");
- }
+ addInput(new UniformRecordGenerator(keyCnt, valCnt, true));
+ addInput(new UniformRecordGenerator(keyCnt, valCnt, true));
- final AtomicBoolean success = new AtomicBoolean(false);
+ final OneShotLatch delayedLatch = new OneShotLatch();
Review Comment:
```suggestion
final OneShotLatch delayCoGroupProcessingLatch = new OneShotLatch();
```
nit on the naming: Could we add the step that is supposed to be delayed here.
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskExternalITCase.java:
##########
@@ -44,7 +44,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
-class ReduceTaskExternalITCase extends
DriverTestBase<RichGroupReduceFunction<Record, Record>> {
+class ReduceTaskExternalITCase extends
DriverTestBase<GroupReduceFunction<Record, Record>> {
Review Comment:
Why is this change necessary? :thinking:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
