XComp commented on code in PR #23770:
URL: https://github.com/apache/flink/pull/23770#discussion_r1403082430
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskTest.java:
##########
@@ -50,7 +50,7 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.fail;
-public class ReduceTaskTest extends
DriverTestBase<RichGroupReduceFunction<Record, Record>> {
+public class ReduceTaskTest extends DriverTestBase<GroupReduceFunction<Record,
Record>> {
Review Comment:
Ah, I see. I missed that one :+1: Even though, one could argue that instead
of fixing the generic you could just switch to the not-deprecated
`DriverTestBase#testDriver(Driver, S)` method which you introduced (that would
reduce the deprecation warning at least for these tests). But I leave it up to
you whether you still want to change that. :shrug:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
