Jiabao-Sun commented on code in PR #23770:
URL: https://github.com/apache/flink/pull/23770#discussion_r1403048440
##########
flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskTest.java:
##########
@@ -50,7 +50,7 @@
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.fail;
-public class ReduceTaskTest extends
DriverTestBase<RichGroupReduceFunction<Record, Record>> {
+public class ReduceTaskTest extends DriverTestBase<GroupReduceFunction<Record,
Record>> {
Review Comment:
This is necessary because we have change the parameter from `Class
stubClass` to `Class<? extends S> stubClass`.
The `ReduceTaskTest`'s `MockCombiningReduceStub` implements
`GroupReduceFunction`.
If we continue to use `DriverTestBase<RichGroupReduceFunction<Record,
Record>>`, we will exceed the specified boundaries.
https://github.com/apache/flink/blob/c61c09e464073fae430cab2dd56bd608f9d275fd/flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskTest.java#L316-L318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
