afedulov commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1412106299
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -180,13 +190,28 @@ public void reconcile(FlinkResourceContext<CR> ctx)
throws Exception {
}
}
- private void applyAutoscaler(FlinkResourceContext<CR> ctx) throws
Exception {
+ private void applyAutoscaler(FlinkResourceContext<CR> ctx, @Nullable
String existingOverrides)
+ throws Exception {
var autoScalerCtx = ctx.getJobAutoScalerContext();
boolean autoscalerEnabled =
ctx.getResource().getSpec().getJob() != null
&&
ctx.getObserveConfig().getBoolean(AUTOSCALER_ENABLED);
autoScalerCtx.getConfiguration().set(AUTOSCALER_ENABLED,
autoscalerEnabled);
+
autoscaler.scale(autoScalerCtx);
Review Comment:
Maybe add a comment to the section below explaining why this call to `scale`
does not lead to the unnecessary update if we only patch the new config after
it. I personally do not directly understand why this is the case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
