gyfora commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1412164693
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -137,7 +141,13 @@ public void reconcile(FlinkResourceContext<CR> ctx) throws
Exception {
cr.getStatus().getReconciliationStatus().deserializeLastReconciledSpec();
SPEC currentDeploySpec = cr.getSpec();
- applyAutoscaler(ctx);
+ applyAutoscaler(
+ ctx,
+ lastReconciledSpec != null
Review Comment:
I think we should extract the configs through the ctx and avoid the extra
logic and parameter passing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
