mxm commented on code in PR #721:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/721#discussion_r1412176016
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -180,13 +190,28 @@ public void reconcile(FlinkResourceContext<CR> ctx)
throws Exception {
}
}
- private void applyAutoscaler(FlinkResourceContext<CR> ctx) throws
Exception {
+ private void applyAutoscaler(FlinkResourceContext<CR> ctx, @Nullable
String existingOverrides)
+ throws Exception {
var autoScalerCtx = ctx.getJobAutoScalerContext();
boolean autoscalerEnabled =
ctx.getResource().getSpec().getJob() != null
&&
ctx.getObserveConfig().getBoolean(AUTOSCALER_ENABLED);
autoScalerCtx.getConfiguration().set(AUTOSCALER_ENABLED,
autoscalerEnabled);
+
autoscaler.scale(autoScalerCtx);
+
+ // Check that the overrides actually changed and not merely the String
representation
+ var flinkConfig = ctx.getResource().getSpec().getFlinkConfiguration();
+ var newOverrides =
flinkConfig.get(PipelineOptions.PARALLELISM_OVERRIDES.key());
Review Comment:
I'm curious, why is it not safe?
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -137,7 +141,13 @@ public void reconcile(FlinkResourceContext<CR> ctx) throws
Exception {
cr.getStatus().getReconciliationStatus().deserializeLastReconciledSpec();
SPEC currentDeploySpec = cr.getSpec();
- applyAutoscaler(ctx);
+ applyAutoscaler(
+ ctx,
+ lastReconciledSpec != null
Review Comment:
Sure, let me look into that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
