Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2756#discussion_r87802539
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
 ---
    @@ -459,7 +545,28 @@ public WindowedStream(KeyedStream<T, K> input,
         * @param resultType Type information for the result type of the window 
function
         * @return The data stream that is the result of applying the window 
function to the window.
         */
    -   public <R> SingleOutputStreamOperator<R> apply(R initialValue, 
FoldFunction<T, R> foldFunction, WindowFunction<R, R, K, W> function, 
TypeInformation<R> resultType) {
    +   public <R> SingleOutputStreamOperator<R> apply(R initialValue, 
FoldFunction<T, R> foldFunction,
    --- End diff --
    
    I think we can already implement 
https://issues.apache.org/jira/browse/FLINK-3869 (see my last comment there) 
for the `ProcessWindowFunction`. I.e. don't have `apply(ReduceFunction, 
WindowFunction)` but `reduce(ReduceFunction, ProcessWindowFunction)` (same for 
fold).
    
    Also, `apply(R, FoldFunction, WindowFunction)` has a bug, in that it is too 
restrictive, see the Jira issue I linked.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to