Github user aljoscha commented on a diff in the pull request:

    https://github.com/apache/flink/pull/2756#discussion_r88001538
  
    --- Diff: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/WindowedStream.java
 ---
    @@ -800,4 +907,39 @@ public StreamExecutionEnvironment 
getExecutionEnvironment() {
        public TypeInformation<T> getInputType() {
                return input.getType();
        }
    +
    +   private static <T, R, K, W extends Window> ProcessWindowFunction<T, R, 
K, W> wrapWindowFunction(final WindowFunction<T, R, K, W> cleanedFunction) {
    --- End diff --
    
    I see, I'm afraid I didn't communicate that very well.
    
    For `WindowOperator` the user facing `WindowFunction` is already abstracted 
from the actual `WindowOperator` by the `InternalWindowFunction`. I just 
realised that these "AlignedProcessingTimeWindowOperators" don't have that 
abstraction  and directly take a `WindowFunction`, there we would have to 
introduce some level of nesting, either by wrapping a `WindowFunction` in a 
`ProcessWindowFunction` or by also using `InternalWindowFunction` there. Thing 
is, though, that these operators will be removed because their state cannot 
easily made repartitionable (see the work that we did on key-groups and 
repartitionable state).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to