yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433735764
##########
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/CancelPartitionRequestTest.java:
##########
@@ -100,7 +102,12 @@ void testCancelPartitionRequest() throws Exception {
Channel ch = connect(serverAndClient);
// Request for non-existing input channel => results in cancel
request
Review Comment:
This test class mainly verifies cases when the input channel does not exist,
as shown in `CreditBasedPartitionRequestClientHandler`
```java
RemoteInputChannel inputChannel = inputChannels.get(announcement.receiverId);
if (inputChannel == null || inputChannel.isReleased()) {
cancelRequestFor(announcement.receiverId);
return;
}
```
Thus the comment here has been correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
