yunfengzhou-hub commented on code in PR #23927:
URL: https://github.com/apache/flink/pull/23927#discussion_r1433752308
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/consumer/SingleInputGate.java:
##########
@@ -281,15 +271,9 @@ public SingleInputGate(
this.bufferDebloater = bufferDebloater;
this.throughputCalculator = checkNotNull(throughputCalculator);
- this.tieredStorageConsumerClient = tieredStorageConsumerClient;
- this.tieredStorageConsumerSpecs = tieredStorageConsumerSpecs;
- if (enabledTieredStorage()) {
- this.availabilityNotifier = new AvailabilityNotifierImpl();
- setupTieredStorageNettyService(nettyService,
tieredStorageConsumerSpecs);
-
tieredStorageConsumerClient.registerAvailabilityNotifier(availabilityNotifier);
- } else {
- this.availabilityNotifier = null;
- }
+ this.tieredStorageConsumerClient = null;
Review Comment:
In this pull request we added `TieredStorageInputChannelId` to
`TieredStorageConsumerSpec`, which theoretically can only be acquired after the
input channel is created (despite that `TieredStorageInputChannelId` only
relies on inputchannels' indexes for now, which can be determined before the
creation of the input channels). Given that input channel is initialized after
SingleInputGate is created, we should also move the init process of tiered
storage services to after SingleInputGate's construction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
