jiangxin369 commented on code in PR #23957:
URL: https://github.com/apache/flink/pull/23957#discussion_r1436042917
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemorySpec.java:
##########
@@ -30,9 +30,21 @@ public class TieredStorageMemorySpec {
/** The number of guaranteed buffers of this memory owner. */
private final int numGuaranteedBuffers;
+ /**
+ * Whether the buffers of this owner can definitely be recycled, even if
the downstream does not
+ * consume them promptly.
+ */
+ private final boolean definitelyRecycled;
Review Comment:
IMO, these are two distinct concepts. For instance, a `BufferAccumulator`
should be `DefinitelyRecycled`, but not contain
`bufferReclaimRequestListeners`, and currently, there is no evidence to prove
that a `DefinitelyRecycled Tier` must contain `bufferReclaimRequestListeners`.
Therefore, I don't think we need to couple these two concepts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
