jiangxin369 commented on code in PR #23957:
URL: https://github.com/apache/flink/pull/23957#discussion_r1444373389
##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/tiered/storage/TieredStorageMemorySpec.java:
##########
@@ -30,9 +30,21 @@ public class TieredStorageMemorySpec {
/** The number of guaranteed buffers of this memory owner. */
private final int numGuaranteedBuffers;
+ /**
+ * Whether the buffers of this owner can definitely be recycled, even if
the downstream does not
+ * consume them promptly.
+ */
+ private final boolean definitelyRecycled;
Review Comment:
Thanks for the review.
1. Yes, `guaranteedRecyclable` is more acceptable, however, I found that we
already have such a concept in `TieredStorageMemoryManager` called
`reclaimable`. To keep consistency, I named it `guaranteedReclaimable`, please
feel free to bring it up if you have other alternatives.
2. Currently, I have not thought of such a scenario, so I think maybe we can
keep the current design. If we find a scenario requires a tier to contain both
types of buffers, the current implementation can be transferred to the new
design smoothly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
