JunRuiLee commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1450526101
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##########
@@ -82,7 +83,8 @@ public void setUp() {
@Test
public void testImmediateCheckpointing() throws Exception {
env.setRestartStrategy(RestartStrategies.noRestart());
- env.enableCheckpointing(Long.MAX_VALUE - 1);
+ env.enableCheckpointing(
+ Duration.ofNanos(Long.MAX_VALUE /* max allowed by FLINK
*/).toMillis());
Review Comment:
Because this pr make the env.enableCheckpointing updates the env's
configuration. This configuration is utilized as the cluster config when using
LocalExecutor. Consequently, there are places where the toMap method of the
configuration is invoked, such as within the constructor of
ClusterConfigHandler.
However, in Flink the conversion between Duration and String requires that
the maximum value for Duration corresponds to the number of nanoseconds in
Long.MAX_VALUE. Thus, this change was made to adhere to this requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
