hunter-cloud09 commented on PR #740: URL: https://github.com/apache/flink-kubernetes-operator/pull/740#issuecomment-1880874500
> I really don't understand the purpose of this change. Previously we always set `FINISHED` state after cancelling the job. > > Now you set CANCELLED in some place and FINISHED in others. Why is that better? Makes the code more complex without any benefit apparently One thing I really don’t understand is why there is a FINISHED status in the middle of canceling a job. Shouldn't the result of canceling a job just be CANCELED? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
