hunter-cloud09 commented on code in PR #740:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/740#discussion_r1449726381
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -369,16 +370,17 @@ protected void cancelJob(
deleteClusterDeployment(
deployment.getMetadata(), deploymentStatus,
conf, true);
}
+
deploymentStatus.getJobStatus().setState(JobStatus.FINISHED.name());
break;
case LAST_STATE:
deleteClusterDeployment(
deployment.getMetadata(), deploymentStatus, conf,
false);
+
deploymentStatus.getJobStatus().setState(JobStatus.FINISHED.name());
break;
default:
throw new RuntimeException("Unsupported upgrade mode " +
upgradeMode);
}
}
- deploymentStatus.getJobStatus().setState(JobStatus.FINISHED.name());
Review Comment:
Because we ran into this problem when we were doing job ops, the cancel job
intermediate state always had `FINISHED`, which is not right for our business.
So I don't think it's right for the program.
On another note, I'd like to ask what was the reason for doing this in the
first place? Is it normal to have an intermediate state finished for cancel
requests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
