gyfora commented on code in PR #740:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/740#discussion_r1452031302
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/service/AbstractFlinkService.java:
##########
@@ -369,16 +370,17 @@ protected void cancelJob(
deleteClusterDeployment(
deployment.getMetadata(), deploymentStatus,
conf, true);
}
+
deploymentStatus.getJobStatus().setState(JobStatus.FINISHED.name());
break;
case LAST_STATE:
deleteClusterDeployment(
deployment.getMetadata(), deploymentStatus, conf,
false);
+
deploymentStatus.getJobStatus().setState(JobStatus.FINISHED.name());
break;
default:
throw new RuntimeException("Unsupported upgrade mode " +
upgradeMode);
}
}
- deploymentStatus.getJobStatus().setState(JobStatus.FINISHED.name());
Review Comment:
So to reiterate:
1. The current behaviour is the simplest and is correct from the operator's
perspective.
2. If users rely on the content of the cr status to tell how exactly the job
was stopped, it could be improved. But we should try not to complicate it too
much.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
