StefanRRichter commented on code in PR #24031:
URL: https://github.com/apache/flink/pull/24031#discussion_r1447406064
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/contrib/streaming/state/RocksDBOperationUtils.java:
##########
@@ -230,6 +252,19 @@ private static ColumnFamilyHandle createColumnFamily(
}
}
+ private static ColumnFamilyHandle createColumnFamilyWithImport(
+ ColumnFamilyDescriptor columnDescriptor,
+ RocksDB db,
+ List<ExportImportFilesMetaData> metaDataList) {
+ try {
+ return db.createColumnFamilyWithImport(
+ columnDescriptor, new ImportColumnFamilyOptions(),
metaDataList);
+ } catch (RocksDBException e) {
+ IOUtils.closeQuietly(columnDescriptor.getOptions());
+ throw new FlinkRuntimeException("Error creating
ColumnFamilyHandle.", e);
Review Comment:
I modified the code in a different way that makes sure the cleanup happens
through the owner of the objects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
