StefanRRichter commented on code in PR #24031:
URL: https://github.com/apache/flink/pull/24031#discussion_r1447508385
##########
flink-state-backends/flink-statebackend-rocksdb/src/test/java/org/apache/flink/contrib/streaming/state/RocksIncrementalCheckpointRescalingTest.java:
##########
@@ -41,14 +41,26 @@
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import java.util.Arrays;
+import java.util.Collection;
import java.util.List;
/** Tests to guard rescaling from checkpoint. */
+@RunWith(Parameterized.class)
public class RocksIncrementalCheckpointRescalingTest extends TestLogger {
@Rule public TemporaryFolder rootFolder = new TemporaryFolder();
+ @Parameterized.Parameters(name = "useIngestDbRestoreMode: {0}")
+ public static Collection<Boolean> parameters() {
+ return Arrays.asList(false, true);
+ }
+
+ @Parameterized.Parameter public boolean useIngestDbRestoreMode;
Review Comment:
Not the FileStateBackend, because this only affects RocksDB. But there are
also more rescaling tests that could cover this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
