zhuzhurk commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451772433
##########
flink-tests/src/test/java/org/apache/flink/test/checkpointing/CheckpointAfterAllTasksFinishedITCase.java:
##########
@@ -82,7 +83,8 @@ public void setUp() {
@Test
public void testImmediateCheckpointing() throws Exception {
env.setRestartStrategy(RestartStrategies.noRestart());
- env.enableCheckpointing(Long.MAX_VALUE - 1);
+ env.enableCheckpointing(
+ Duration.ofNanos(Long.MAX_VALUE /* max allowed by FLINK
*/).toMillis());
Review Comment:
I see. What confused me is that it changes `Long.MAX_VALUE - 1` to
`Long.MAX_VALUE`. I think these two numbers do not make actual differences
though.
Besides that, I can see other usages of `enableCheckpointing(...)` which
passes in a large number, e.g.
`CheckpointAfterAllTasksFinishedITCase#testRestoreAfterSomeTasksFinished()` and
`RestoreUpgradedJobITCase#runOriginalJob()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
