zhuzhurk commented on code in PR #24025:
URL: https://github.com/apache/flink/pull/24025#discussion_r1451774802
##########
flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java:
##########
@@ -140,7 +140,7 @@ public StreamGraph(
ExecutionConfig executionConfig,
CheckpointConfig checkpointConfig,
SavepointRestoreSettings savepointRestoreSettings) {
- this.jobConfiguration = checkNotNull(jobConfiguration);
+ this.jobConfiguration = new Configuration(jobConfiguration);
Review Comment:
Maybe `new Configuration(checkNotNull(jobConfiguration));`?
##########
flink-streaming-java/src/test/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironmentTest.java:
##########
@@ -446,16 +446,20 @@ void testBufferTimeoutEnabled() {
void testBufferTimeoutDisabled() {
Configuration config = new Configuration();
config.set(ExecutionOptions.BUFFER_TIMEOUT_ENABLED, false);
- StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment();
+ StreamExecutionEnvironment env =
StreamExecutionEnvironment.getExecutionEnvironment(config);
Review Comment:
Not sure why passing the config in here? It will be used in
`env.configure()` right after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
