ryanvanhuuksloot commented on code in PR #755:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1452524915
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends
CommonStatus<FlinkDeploymentSpec> {
/** Information about the TaskManagers for the scale subresource. */
private TaskManagerInfo taskManager;
+
+ /** Last observed generation of the FlinkDeployment. */
+ private Long observedGeneration;
Review Comment:
>We do have this information available already, via the lastReconciledSpec
field. Not sure whether we need to expose this as a top-level field.
The idea is that the Kubernetes spec expects that this status field exists
in this particular place. This type of PR allows for 3rd party tools to work
well with the Flink Operator. (ie. our build tools internally now can
communicate with the operator which is 🙏)
However, agreed with Gyula on how it should replace semantically what exists
today.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
