mxm commented on code in PR #755:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1457361368
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends
CommonStatus<FlinkDeploymentSpec> {
/** Information about the TaskManagers for the scale subresource. */
private TaskManagerInfo taskManager;
+
+ /** Last observed generation of the FlinkDeployment. */
+ private Long observedGeneration;
Review Comment:
In essence, the current code already reflected the desired functionality, we
just need to move the code to set the top-level generation id to where we
initially set it. I hope that's easily doable. If not, let us know.
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends
CommonStatus<FlinkDeploymentSpec> {
/** Information about the TaskManagers for the scale subresource. */
private TaskManagerInfo taskManager;
+
+ /** Last observed generation of the FlinkDeployment. */
+ private Long observedGeneration;
Review Comment:
In essence, the current code already reflects the desired functionality, we
just need to move the code to set the top-level generation id to where we
initially set it. I hope that's easily doable. If not, let us know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
