justin-chen commented on code in PR #755:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/755#discussion_r1456093406
##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/status/FlinkDeploymentStatus.java:
##########
@@ -55,4 +55,7 @@ public class FlinkDeploymentStatus extends
CommonStatus<FlinkDeploymentSpec> {
/** Information about the TaskManagers for the scale subresource. */
private TaskManagerInfo taskManager;
+
+ /** Last observed generation of the FlinkDeployment. */
+ private Long observedGeneration;
Review Comment:
> we should set the new field next to where the old one is set so that the
old logic is easy to remove later
@gyfora Not sure I understand, is the intention to duplicate the
`observedGeneration` such that it's available via both
`status.observedGeneration` (we need it at this top level) and
`status.reconciliationStatus.lastReconciledSpec.resource_metadata`?
Given the status currently looks like this (with my current PR):
```
status:
...
observedGeneration: 123
reconciliationStatus:
lastReconciledSpec: '{
"spec": {
...
},
"resource_metadata": {
"apiVersion": "flink.apache.org/v1beta1",
"metadata": { // io.fabric8.kubernetes.api.model.ObjectMeta
"generation": 123
},
"firstDeployment": false
}
}'
lastStableSpec: '{...}'
reconciliationTimestamp:
state: DEPLOYED
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
